Test runner output only partially commented

[stefan-toubia]

When a test run fails and shows the expected/actual diffs, only the first line is commented

 ; expected: #{{:id 1002197,
   :display-name "Campaign 1002198",
   :state "enabled"}}
; actual:  (#{{:id 1002197,
    :display-name "Campaign 1002198",
    :state "enabled"}})

It seems preferable that the diff output would not be commented, maybe there should always be a new line after expected and actual so that the text is commented but the output is not?

 ; expected:
#{{:id 1002197,
   :display-name "Campaign 1002198",
   :state "enabled"}}
; actual:
(#{{:id 1002197,
    :display-name "Campaign 1002198",
    :state "enabled"}})

While we're at it, I was wondering if there's a reason the actual output is always in a list () whereas expected is not formatted this way?

Last thing, I'm liking the new output method with the file, much more reliable doing paredit in an actual file, I'm imagining it's less complex than having a whole repl window module too! Do you know if it's possible to customize the color of the comments in this file alone? Green seems pretty appropriate in normal cases, but is a bit hard to read large blocks of for the test runner output.

[PEZ]

While I think that this last thing should go in an issue of its own, I can't resist commenting on it. 😄 Yes, it is possible. But it would need to be done via the highlight module, I can talk you through it some on slack or something, if you want to take it on.

[bpringe]

So, Calva is calling test-var-query from cider-nrepl to run tests and get results. Those results are coming back with actual being a list, and I'm not sure why. @bbatsov might have more insight here - I also pinged him in slack.

Another thing that confuses me is when I run a test to simulate your output, it all comes back on one line in the results (no newline characters). With this test:

(with-test
  (defn foo []
    #{{:id 1010101
       :display-name "Campaign 1010101"
       :state "enabled"}})
  (is (= #{{:id 1010102
            :display-name "Campaign 1010101"
            :state "enabled"}} 
         (foo))))

I get these results (as seen in the debug pane):

And hence it prints in the output window like:

; Running test: foo…
; FAIL in core/foo (core.clj:24):
;   expected: #{{:id 1010102, :display-name "Campaign 1010101", :state "enabled"}}
;   actual: (#{{:id 1010101, :display-name "Campaign 1010101", :state "enabled"}})
; 1 tests finished, problems found. 😭 errors: 0, failures: 1, ns: 1, vars: 1

[bpringe]

I guess the newline thing could be my pprint settings... I'll look into that.

Edit: Yes 😆, it just wasn't wrapping because it wasn't large enough. Will carry on...

[bpringe]

@stefan-toubia Please try this vsix and let me know if it looks good to you. https://8033-125431277-gh.circle-artifacts.com/0/tmp/artifacts/calva-2.0.125-fix-test-runner-output-51ad1b13.vsix

[stefan-toubia]

@bpringe Another great fix, thanks!

[PEZ]

I'm lazy, so haven't checked before suggesting: Make an issue for the extra parens things. They have bit me many times, but lately I have finally learnt to ignore them, which is totally the wrong solution.

[bpringe]

I've made a new issue, #794. Knowing what I know, I'm assuming it's an upstream issue and tagged Bozhidar Batsov in that thread.