Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop bundling clj-kondo in favor of using it through clojure-lsp #868

Closed
bpringe opened this issue Dec 11, 2020 · 2 comments
Closed

Stop bundling clj-kondo in favor of using it through clojure-lsp #868

bpringe opened this issue Dec 11, 2020 · 2 comments

Comments

@bpringe
Copy link
Member

bpringe commented Dec 11, 2020

This task is for later, after clojure-lsp integration with Calva is released.

Currently there are a couple small issues with clojure-lsp's diagnostics, and until those are fixed, we'll just keep using the clj-kondo extension.

Clojure-lsp, at this time, does offer at least one thing clj-kondo does not (that I can tell), and that is showing unused public variables.

image

simple in the above is unused in the code base - clojure-lsp tells me this, but clj-kondo does not (only thing providing diagnostics in the above).

@ericdallo
Copy link
Contributor

@bpringe all those issues were fixed :)

@bpringe
Copy link
Member Author

bpringe commented Dec 27, 2020

Awesome! Thank you, sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants