Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clojure-lsp for usages for debug instrumentation decorations, and stop injecting clj-kondo at jack-in #931

Closed
bpringe opened this issue Jan 5, 2021 · 3 comments

Comments

@bpringe
Copy link
Member

bpringe commented Jan 5, 2021

This way we can remove a jack-in dependency, as well as stop an unnecessary cache directory from being created (I think - see #930).

This would, of course, increase our dependency on clojure-lsp for existing features, making it harder to disable. However, I think in a short time we won't be concerned with allowing it to be disabled and can make Calva lean into it as a requirement, as it already tentatively does 😄.

@ericdallo
Copy link
Contributor

Also adds the feature that users wouldn't need to jack in to have linter feature :)

@bpringe
Copy link
Member Author

bpringe commented Jan 5, 2021

To be clear, they don't currently need to jack-in for linting, as this is provided from the clj-kondo VS Code extension. This is related specifically to the debugger and how it "highlights" what functions are instrumented for debugging, as seen in the gif at the top here: https://calva.io/debugger/

@ericdallo
Copy link
Contributor

Oh, got it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants