Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to provide implementations of vscode/node interfaces #119

Closed
PEZ opened this issue Dec 21, 2022 · 0 comments · Fixed by #120
Closed

Document how to provide implementations of vscode/node interfaces #119

PEZ opened this issue Dec 21, 2022 · 0 comments · Fixed by #120
Labels
api documentation Improvements or additions to documentation

Comments

@PEZ
Copy link
Collaborator

PEZ commented Dec 21, 2022

When I wanted to create a VS Code hover provider I immediately went for:

(deftype HoverProvider []
                       Object
  (provideHover [doc pos] ...))

Which doesn't work in Joyride SCI.

It is not necessary either. This suffices:

#js {:provideHover (fn [doc pos] ...)}

The latter should not be instantiated either. Just be used wherever a instance is expected.
@PEZ PEZ added documentation Improvements or additions to documentation api labels Dec 21, 2022
PEZ added a commit that referenced this issue Dec 21, 2022
@PEZ
Update template user_activate
e33e449 
Update api docs

Fixes #119
@PEZ PEZ mentioned this issue Dec 21, 2022
Merged
@PEZ PEZ closed this as completed in #120 Dec 21, 2022
PEZ added a commit that referenced this issue Dec 21, 2022
@PEZ
Pez/hover example (#120)
79cbcb8 
* Update template user_activate

Update api docs

Fixes #119

* Add caveat about symbols example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pez/hover example BetterThanTomorrow/joyride
1 participant
@PEZ