Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow that will upload code coverage after a merge to main #65

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

btrautmann
Copy link
Contributor

@btrautmann btrautmann commented Jun 15, 2022

Description

I noticed on previous PRs that Codecov reports were not showing the diff in coverage compared to main because it couldn't find previously uploaded reports because we squash commits, therefore changing the sha on main and causing Codecov being unable to associate the commits on main with previous uploads. By uploading them for the latest sha on main it will now be able to find them.

I went with this approach as opposed to adding a push trigger to the main workflow because that one does format and analyze which we don't need to do.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

…. this is necessary to allow showing a diff in coverage for PRs due to the nature of us squashing commits to main, changing the sha and causing codecov to be unable to find the commit on main associated with previously uploaded reports.
Copy link
Collaborator

@Kirpal Kirpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@d928855). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main       #65   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        12           
  Lines           ?       506           
  Branches        ?         0           
========================================
  Hits            ?       506           
  Misses          ?         0           
  Partials        ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d928855...0f89b38. Read the comment docs.

@btrautmann btrautmann merged commit 9406f3a into main Jun 15, 2022
@btrautmann btrautmann deleted the brandon/add-main-cov-upload-workflow branch June 15, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants