Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render objects not rendering text #98

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

Kirpal
Copy link
Collaborator

@Kirpal Kirpal commented Sep 11, 2023

Description

Fixes issue on Flutter 3.13 where text drawn by a render object widget was not rendering correctly. Fixes #97

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0a8b653) 100.00% compared to head (7feac64) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          559       562    +3     
=========================================
+ Hits           559       562    +3     
Files Changed Coverage Δ
lib/src/blocked_text_image.dart 100.00% <100.00%> (ø)
lib/src/golden_test_adapter.dart 100.00% <100.00%> (ø)
lib/src/golden_test_runner.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@marcossevilla marcossevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Collaborator

@jeroen-meijer jeroen-meijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! :shipit:

@Kirpal Kirpal merged commit ac2c611 into main Sep 13, 2023
5 checks passed
@Kirpal Kirpal deleted the fix/3-13-render-object branch September 13, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Flutter 3.13.1 - Custom RenderObjects are not visible anymore on golden images
3 participants