Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubygems description and add CHANGELOG #1

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

smudge
Copy link
Member

@smudge smudge commented Aug 19, 2021

/domain @samandmoore @effron
/no-platform

This fixes the gemspec description, which had previously been written in rdoc format (causing it to appear garbled on rubygems.org). It also adds a CHANGELOG and bumps the version to 0.1.1.

@nanda-prbot
Copy link

Needs somebody from @samandmoore and @effron to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@samandmoore
Copy link
Member

<<domainlgtm

once you merge, you'll have to tag and release this. i DM'd you some stuff about how i've been doing semi-manual release stuff for other gems.

Copy link

@nanda-prbot nanda-prbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🌟 ⭐ 🍟

@smudge smudge merged commit 941f02d into Betterment:main Aug 19, 2021
@smudge smudge deleted the fix-rubygems-description branch August 19, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants