Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ruby & Rails version support #13

Merged
merged 9 commits into from
Jan 4, 2024
Merged

Update Ruby & Rails version support #13

merged 9 commits into from
Jan 4, 2024

Conversation

Irving-Betterment
Copy link
Contributor

@Irving-Betterment Irving-Betterment commented Dec 29, 2023 •
edited
Loading

Summary of changes:

  • Add Ruby 3.2 support.
  • Drop end of life Ruby and Rails versions support.
  • Address rubocop offenses (detailed per commit).

/task https://app.asana.com/0/1206095065335149/1206255334170330/f

@Irving-Betterment Irving-Betterment marked this pull request as ready for review December 29, 2023 23:27
effron
effron approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@effron effron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM && platformLGTM

smudge
smudge approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM && platform LGTM

@smudge smudge merged commit 3009b8a into Betterment:main Jan 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smudge smudge smudge approved these changes

@effron effron effron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Irving-Betterment @smudge @effron