Clean out finished_at in create #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs somebody from @Betterment/test_track_core to claim domain review Use the shovel operator to claim, e.g.:
|
coreyja
reviewed
Mar 7, 2019
| @@ -7,6 +7,7 @@ class SplitCreation | |||
| validate :split_must_be_valid | |||
|
|
|||
| def save | |||
| split.finished_at = nil | |||
There was a problem hiding this comment.
❤️ Love when it really is this easy!
|
<< domain LGTM |
|
Approved! 🙏 🎇 👏 |
nonrational
pushed a commit
to bymealpal/test_track
that referenced
this pull request
Mar 19, 2019
* upstream/master: Upgrade rails (Betterment#95) Clean out finished_at in create (Betterment#94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you want to reenable a finished split via a migration, it won't actually un-finish it. This fixes that.
/domain @Betterment/test_track_core
/no-platform