update naming

Betterment · Apr 28, 2017 · df57691 · df57691
1 parent 57b6415
commit df57691
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/app/models/test_track/session.rb b/app/models/test_track/session.rb
@@ -122,7 +122,7 @@ def response_headers
   end
 
   def manage_response_headers!
-    response_headers[visitor_response_header_name] = visitor.id if visitor.id_changed?
+    response_headers[visitor_response_header_name] = visitor.id if visitor.id_overridden_by_existing_visitor?
   end
 
   def notify_unsynced_assignments!

diff --git a/app/models/test_track/visitor.rb b/app/models/test_track/visitor.rb
@@ -98,8 +98,8 @@ def loaded?
     !offline? && @remote_visitor.present?
   end
 
-  def id_changed?
-    @id_changed || false
+  def id_overridden_by_existing_visitor?
+    @id_overridden_by_existing_visitor || false
   end
 
   private
@@ -117,7 +117,7 @@ def remote_visitor
   end
 
   def merge!(other)
-    @id_changed = id != other.id
+    @id_overridden_by_existing_visitor = id != other.id
     @id = other.id
     @assignment_registry = assignment_registry.merge(other.assignment_registry)
     @unsynced_assignments = nil

diff --git a/spec/models/test_track/session_spec.rb b/spec/models/test_track/session_spec.rb
@@ -73,7 +73,7 @@
             subject.log_in!("identifier_type", "value")
           end
 
-          expect(controller.response.headers['X-Set-TT-Visitor-ID']).to eq(nil)
+          expect(controller.response.headers).not_to have_key('X-Set-TT-Visitor-ID')
         end
       end