Add support for rails 6 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smudge
reviewed
Jan 7, 2020
.travis.yml
Outdated
| - gemfiles/rails_6_0.gemfile | ||
|
|
||
| matrix: | ||
| allow_failures: |
|
Changing the min required ruby version is probably a breaking change, right? We can probably do away with that for the sake of existing apps on older rubies, no? << platform TAFN |
|
Needs somebody from @Betterment/test_track_core to claim domain review Use the shovel operator to claim, e.g.:
|
|
bump, I reverted updating the min required ruby and updated the travis config. |
|
Needs somebody from @Betterment/test_track_core to claim domain review Use the shovel operator to claim, e.g.:
|
|
<< domain LGTM && platform LGTM |
|
Approved! 🙌 👻 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/domain @Betterment/test_track_core
/platform @aburgel @jmileham @effron @smudge
In the path to upgrading, I've been running around resolving a bit of dependency hell 🔥.
The diff here is a lot larger than it is significant.
changes
update ruby-version to 2.6 which is required by rails 6 (well it requires 2.5+ but why not... 🤷♂)
ruby 2.6 is not supported by rubocop 0.51.0, so I updated that to 0.61.0
The newer version of rubocop has a lot of "suggestions" for this repo so I ran
bundle exec rubocop --auto-correctand thenrm .rubocop_todo.yml; bundle exec rubocop --auto-gen-configto ignore anything that wasn't auto corrected.generate a rails 6 appraisal
update the build matrix to include the rails 6 appraisal.
notes
If there's disagreement with the changes that rubocop --auto-correcting has introduced, I'm happy to shunt the entire thing into the todo.yml.
Also, I'm not very familiar with the internals of test track. If there are tests I should add so we can feel confident supporting rails 6, give me a shout!