-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax version constraint on webmock. #22
Relax version constraint on webmock. #22
Conversation
webvalve appears to be compatible with Webmock 3+ (tested with v3.4.2)
@messanjah needs to request domain and platform reviewers. |
Not sure who to request as reviewers. 😅From looking at other PRs, I'm guessing: /domain @samandmoore |
Needs somebody from @samandmoore to claim domain review Use the shovel operator to claim, e.g.:
|
hi @messanjah! yes, i will take a look. thanks for opening this up. i haven't had a chance to dig in and make sure there were no breaking changes in the latest webmock version. i will take a look and then review. |
<<domain platform |
Needs @samandmoore to provide platform review When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:
If you're too busy to review, unclaim the PR, e.g.:
|
okay! i ran this on a Betterment app's test suite and everything was 🆗 . so i'm happy to merge away. thanks @messanjah for opening this PR. |
domainlgtm platformlgtm |
Approved! 🌞 🔩 👏 |
released here! https://rubygems.org/gems/webvalve/versions/0.9.6 |
Wow, thanks for the super fast turnaround! |
webvalve appears to be compatible with Webmock 3+ (tested with v3.4.2)