Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax version constraint on webmock. #22

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

messanjah
Copy link
Contributor

webvalve appears to be compatible with Webmock 3+ (tested with v3.4.2)

webvalve appears to be compatible with Webmock 3+ (tested with v3.4.2)
@nanda-prbot
Copy link

@messanjah needs to request domain and platform reviewers.

@messanjah
Copy link
Contributor Author

Not sure who to request as reviewers. 😅From looking at other PRs, I'm guessing:

/domain @samandmoore
/platform @samandmoore

@nanda-prbot
Copy link

Needs somebody from @samandmoore to claim domain review
Needs somebody from @samandmoore to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

@samandmoore
Copy link
Member

hi @messanjah! yes, i will take a look. thanks for opening this up. i haven't had a chance to dig in and make sure there were no breaking changes in the latest webmock version. i will take a look and then review.

@samandmoore
Copy link
Member

<<domain platform

@nanda-prbot
Copy link

Needs @samandmoore to provide platform review
Needs @samandmoore to provide domain review

When you finish a round of review, be sure to say you've finished or sign off on the PR, e.g.:

TAFN or DomainLGTM

If you're too busy to review, unclaim the PR, e.g.:

@myname >> domain

@samandmoore
Copy link
Member

okay! i ran this on a Betterment app's test suite and everything was 🆗 . so i'm happy to merge away.

thanks @messanjah for opening this PR.

@samandmoore
Copy link
Member

domainlgtm platformlgtm

@nanda-prbot
Copy link

Approved! 🌞 🔩 👏

@samandmoore samandmoore merged commit c93a927 into Betterment:master Jun 27, 2018
@messanjah messanjah deleted the relax-webmock-constraint branch June 27, 2018 16:24
@samandmoore
Copy link
Member

@messanjah
Copy link
Contributor Author

Wow, thanks for the super fast turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants