New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename `whitelist_url` to `allow_url` #33

Merged

samandmoore merged 5 commits into master from sam-allowlist

Sep 9, 2019

Member

samandmoore commented Sep 9, 2019

i think this is maybe the last change before creating a 1.0.0.

we've been in production with this library for a few years and we've pushed it pretty hard.

/domain @smudge @jmileham
/no-platform

i'm making this as a breaking change because we're not at 1.0.0 yet and it's a straightforward upgrade

samandmoore added 2 commits

September 9, 2019 15:24


          renamed all whitelist references to allowlist

1144fbd


          eh, don't like that other name all that much

4c06078

nanda-prbot commented Sep 9, 2019

Needs somebody from @smudge and @jmileham to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

1 similar comment

nanda-prbot commented Sep 9, 2019

Needs somebody from @smudge and @jmileham to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

samandmoore commented

View reviewed changes

README.md Outdated Show resolved Hide resolved


          Update README.md

cc94354

nanda-prbot commented Sep 9, 2019

Needs somebody from @smudge and @jmileham to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

3 similar comments

nanda-prbot commented Sep 9, 2019

Needs somebody from @smudge and @jmileham to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

nanda-prbot commented Sep 9, 2019

Needs somebody from @smudge and @jmileham to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

nanda-prbot commented Sep 9, 2019

Needs somebody from @smudge and @jmileham to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

Member

smudge commented Sep 9, 2019

<< domain LGTM -- but why not allow_url for the config method?

nanda-prbot commented Sep 9, 2019

Approved! ⭐ 💫 🎆

Member Author

samandmoore commented Sep 9, 2019

<< domain LGTM -- but why not allow_url for the config method?

ah yes, let's do that!

samandmoore added 2 commits

September 9, 2019 16:03


          use new suggestion

f590e9d


          update changelog

5e6c627

samandmoore changed the title ~~rename whitelist_url to allowlist_url~~ rename whitelist_url to allow_url

samandmoore merged commit 738bdc1 into master

samandmoore deleted the sam-allowlist branch

September 9, 2019 20:05

nanda-prbot commented Sep 9, 2019

Approved! 😻 👍 💥

nanda-prbot commented Sep 9, 2019

Approved! 🔩 🙏 👍

nanda-prbot commented Sep 9, 2019

Approved! 🔩 🚢 🙏

Member

smudge commented Sep 9, 2019

@samandmoore any idea what @nanda-prbot's going on about?

nanda-prbot commented Sep 9, 2019

Approved! 👻 🎯 ⭐

Member Author

samandmoore commented Sep 9, 2019

Nope. I guess there's a background task that is stuck and keeps retrying.

nanda-prbot commented Sep 9, 2019

Approved! 🙆‍♀️ 🎇 🎸

nanda-prbot commented Sep 10, 2019

Approved! 🎈 🎆 💥

nanda-prbot added the approved label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment