Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow same URLs when HTTP auth not the same #46

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

smudge
Copy link
Member

@smudge smudge commented Apr 27, 2020

/domain @samandmoore @effron
/no-platform

Uncovered another one! We have a case where we want to talk to the same service as two different users. The new "Already stubbed url" exception was blocking this use case because by the time we do the comparison we had already stripped the HTTP auth user/pw out of the URL.

This reworks that one check so that it uses the "full URL" (yeah wasn't sure what to call it) instead of the "service URL" (the one used in the mock, no HTTP auth included).

@nanda-prbot
Copy link

Needs somebody from @samandmoore and @effron to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@samandmoore
Copy link
Member

ah yea. i forgot about this use-case. seems useful to keep it. thanks for adding a test!

<<domainlgtm

let's just run this through our full app test suites to make sure things are working across the board with this fix.

@nanda-prbot
Copy link

Approved! 💥 🙌 🔩

@smudge smudge merged commit 1704b68 into Betterment:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants