Allow same URLs when HTTP auth not the same #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/domain @samandmoore @effron
/no-platform
Uncovered another one! We have a case where we want to talk to the same service as two different users. The new
"Already stubbed url"
exception was blocking this use case because by the time we do the comparison we had already stripped the HTTP auth user/pw out of the URL.This reworks that one check so that it uses the "full URL" (yeah wasn't sure what to call it) instead of the "service URL" (the one used in the mock, no HTTP auth included).