Simplifies logic in action handling functions.

BevanR · Jun 26, 2012 · 20fb3c0 · 20fb3c0
1 parent 43c43d9
commit 20fb3c0
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/scheduler_workbench.module b/scheduler_workbench.module
@@ -146,9 +146,7 @@ function scheduler_workbench_scheduler_api($node, $action) {
  * @param stdClass $node
  */
 function _scheduler_workbench_scheduler_unpublish($node) {
-  $state = variable_get('scheduler_unpublish_moderation_state_' . $node->type, '');
-
-  if (FALSE === empty($state)) {
+  if ($state = variable_get('scheduler_unpublish_moderation_state_' . $node->type, FALSE)) {
     workbench_moderation_moderate($node, $state);
   }
 }
@@ -159,9 +157,7 @@ function _scheduler_workbench_scheduler_unpublish($node) {
  * @param stdClass $node
  */
 function _scheduler_workbench_scheduler_publish($node) {
-  $state = variable_get('scheduler_publish_moderation_state_' . $node->type, '');
-
-  if (FALSE === empty($state)) {
+  if ($state = variable_get('scheduler_publish_moderation_state_' . $node->type, FALSE)) {
     workbench_moderation_moderate($node, $state);
   }
 }