[fix][client] Fixes batch_size not checked in MessageId#fromByteArrayWithTopic #7
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WithTopic Fixes apache#18395 ### Motivation The old version Pulsar clients might not set the `batch_size` field in a batched message id, it will cause `MessageId#fromByteArrayWithTopic`, which only checks the `batch_index` field, fail with IllegalStateException. ### Modifications Check if the `batch_size` field exists in `fromByteArrayWithTopic`. If it doesn't exist, create the `BatchMessageIdImpl` instance with the default batch size (0) and the acker (disabled). Move `MessageIdSerializationTest` to the `pulsar-client` module and add the `testBatchSizeNotSet` to verify the change works.
BewareMyPower
force-pushed
the
bewaremypower/fix-message-id-parse
branch
from
327d3d3
to
928e845
Compare
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache#18395
Motivation
The old version Pulsar clients might not set the
batch_sizefield in a batched message id, it will causeMessageId#fromByteArrayWithTopic, which only checks thebatch_indexfield, fail with IllegalStateException.Modifications
Check if the
batch_sizefield exists infromByteArrayWithTopic. If it doesn't exist, create theBatchMessageIdImplinstance with the default batch size (0) and the acker (disabled).Move
MessageIdSerializationTestto thepulsar-clientmodule and add thetestBatchSizeNotSetto verify the change works.