Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge problem with new vertex paint feature for grease pencil #1412

Closed
ReinerBforartists opened this issue Mar 13, 2020 · 9 comments
Closed
Assignees
Labels
1- Fixed This task is fulfilled 2 - bug It's a bug !! Please make sure that it really is ;)

Comments

@ReinerBforartists
Copy link
Contributor

The newest merge brought us new grease pencil features. And a big problem. A so far unresolveable bug. Vital code looks equal everywhere. I have grepped all the terms. I have compared all the code with Meld a few times. Not to catch. In Blender it works, in Bforartists not.

I have created a branch for just this bug now. It is located here: https://github.com/Bforartists/Bforartists/tree/gpencilvertpaintprob

We need to resolve this bug before we can go on and merge the newest changes into Bforartists master. I don't want to ship the new official version with a known bug of this scope.

How to reproduce. Create a grease pencil object. Switch to the new vertex paint mode. Open the console and watch the error message.

problem

@ReinerBforartists ReinerBforartists added the 2 - bug It's a bug !! Please make sure that it really is ;) label Mar 13, 2020
ReinerBforartists pushed a commit that referenced this issue Mar 14, 2020
… cleanup. updated some addons, checked Bforartists source code against Blender source code, and eliminated some possible trouble makers.
@ReinerBforartists
Copy link
Contributor Author

Updated some addons. And i have compared the source code between Blender and Bforartists again. Catched a few inconsistenices like a missing include. But the baddie here was not part of it.

@ReinerBforartists
Copy link
Contributor Author

Continuing to eliminate all unexpected differences that i stumble across. Found another difference here in the preferences. Grease pencil multisampling ...

gpmultisampling

@ReinerBforartists
Copy link
Contributor Author

ReinerBforartists commented Mar 14, 2020

Wrong alert. Started the wrong bfa version. But found nevertheless a difference in space_userpref.py file ...

ReinerBforartists pushed a commit that referenced this issue Mar 14, 2020
… removed double set of ExperimentalPanel in space_userpref.py
@ReinerBforartists
Copy link
Contributor Author

Most probably the trouble commit: SHA-1: 29f3af9

  • GPencil: Refactor of Draw Engine, Vertex Paint and all internal functions

This commit is a full refactor of the grease pencil modules including Draw Engine, Modifiers, VFX, depsgraph update, improvements in operators and conversion of Sculpt and Weight paint tools to real brushes.

Also, a huge code cleanup has been done at all levels.

Thanks to @Fclem for his work and yo @Pepeland and @mendio for the testing and help in the development.

Differential Revision: https://developer.blender.org/D6293

@ReinerBforartists
Copy link
Contributor Author

Still at evaluating.

We have a missing brush browser content before the stylus pressure strength buttons already. Maybe that's a hot track.

brushbrowsercontent

@ReinerBforartists
Copy link
Contributor Author

Same cause, same dead end. Not to catch.

Starting from scratch now, adding our features back to Blender. This can take a few weeks ...

@ReinerBforartists
Copy link
Contributor Author

First step. The error must reside in release folder. This was the first folder that i have thrown in now. And the error is immediately back. So back to compare the code base.

@ReinerBforartists
Copy link
Contributor Author

ReinerBforartists commented Mar 15, 2020

Nailed it. It's the startup.blend. They have most probably stored something in the file that is still missing in our startup.blend file. And this leads to our none error then.

Seems that we have to recreate all of our layouts now. But at least we have the baddie.

@ReinerBforartists
Copy link
Contributor Author

Fixed in gpencilvertpaintprob branch

Now let's merge it into the syncblendermaster branch, and from there into master ...

@ReinerBforartists ReinerBforartists added the 1- Fixed This task is fulfilled label Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1- Fixed This task is fulfilled 2 - bug It's a bug !! Please make sure that it really is ;)
Projects
None yet
Development

No branches or pull requests

2 participants