New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Iconset #3796
Comments
Would be good to know how. |
That's why i have linked the former commit ;) But feel free to ask in case you get stuck :) |
Will tackle this after 4.0.0 release for 4.1.0 |
It is time... |
It's mainly lots of work ^^ |
But how? The link is broken I think, it would nice to share the link here |
No, the link is not broken, it is all here :) You need to resize the blender_icons.svg to have (ten is a good number) more columns. Change the entries in blender_icons_updates.py to these new values. Then you edit the UI_icons.h, and add these more columns there too. Use the def_icon_blank entries. And add a number behind. The line number is a good idea. First fix the handful remaining def_icon_blank entries to have new numbers. Then you do the same with the cmakelists.txt file in the source\blender\editors\datafiles directory. Then there is the changes at source/blender/editors/interface/interface_icons.c remaining, where you increase the icon_grid_cols to the new values. blender_icons_updates.py has also values here. Then comes the drum roll, followed by recreating the icons, followed by compiling and the big chance that you start to cry because something is missing or doesn't work as expected ... i've been there, every time when i extended the sheet :D |
Will work it after some commission work. Thanks for the deeper explanation. |
You're welcome. Don't hesitate to ask in case you are stuck :) |
Compiling debug, got it I think. |
It's a trap ! |
internals like Blenkernel has nothing to do with addons. The error message does not show here though, i have recreated the icons, did a clean compile, and do not get these kind of errors. All works well. Clearing the cmake cache may help. |
Will recompile from scratch, good point. |
Found the issue, was an old addon referencing icons the wrong way, by index instead of name. |
We run out of icon space again. Who wants to extend the set? I know already how to do it ^^
Related task: #2145
The text was updated successfully, but these errors were encountered: