Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Iconset #3796

Closed
ReinerBforartists opened this issue Sep 19, 2023 · 15 comments
Closed

Extend Iconset #3796

ReinerBforartists opened this issue Sep 19, 2023 · 15 comments
Assignees
Labels
0 - task A normal development task 1- Fixed This task is fulfilled

Comments

@ReinerBforartists
Copy link
Contributor

We run out of icon space again. Who wants to extend the set? I know already how to do it ^^

Related task: #2145

outofspace

@ReinerBforartists ReinerBforartists added the 0 - task A normal development task label Sep 19, 2023
@Draise14
Copy link
Collaborator

Would be good to know how.

@ReinerBforartists
Copy link
Contributor Author

That's why i have linked the former commit ;)

But feel free to ask in case you get stuck :)

@Draise14 Draise14 added the 5 - Postponed Still in the list, but will be done at a later point label Nov 7, 2023
@Draise14
Copy link
Collaborator

Draise14 commented Nov 7, 2023

Will tackle this after 4.0.0 release for 4.1.0

@Draise14 Draise14 removed the 5 - Postponed Still in the list, but will be done at a later point label Nov 29, 2023
@Draise14 Draise14 self-assigned this Jan 13, 2024
@Draise14
Copy link
Collaborator

It is time...

@ReinerBforartists
Copy link
Contributor Author

It's mainly lots of work ^^

@esnosy
Copy link
Collaborator

esnosy commented Jan 14, 2024

But how? The link is broken I think, it would nice to share the link here

@ReinerBforartists
Copy link
Contributor Author

No, the link is not broken, it is all here :)

06f5652

You need to resize the blender_icons.svg to have (ten is a good number) more columns. Change the entries in blender_icons_updates.py to these new values.

Then you edit the UI_icons.h, and add these more columns there too. Use the def_icon_blank entries. And add a number behind. The line number is a good idea. First fix the handful remaining def_icon_blank entries to have new numbers.

Then you do the same with the cmakelists.txt file in the source\blender\editors\datafiles directory. Then there is the changes at source/blender/editors/interface/interface_icons.c remaining, where you increase the icon_grid_cols to the new values. blender_icons_updates.py has also values here.

Then comes the drum roll, followed by recreating the icons, followed by compiling and the big chance that you start to cry because something is missing or doesn't work as expected ... i've been there, every time when i extended the sheet :D

@Draise14
Copy link
Collaborator

Will work it after some commission work. Thanks for the deeper explanation.

@ReinerBforartists
Copy link
Contributor Author

You're welcome. Don't hesitate to ask in case you are stuck :)

@Draise14
Copy link
Collaborator

Compiling debug, got it I think.

Draise14 added a commit that referenced this issue Jan 24, 2024
10 new columns
Draise14 added a commit that referenced this issue Jan 24, 2024
@Draise14 Draise14 added the 1- Fixed This task is fulfilled label Jan 24, 2024
@Draise14
Copy link
Collaborator

Draise14 commented Jan 25, 2024

image

Maybe spoke too soon. Can't find two icon ID's.

EDIT: not sure if from an addon though...

@Draise14 Draise14 reopened this Jan 25, 2024
@ReinerBforartists
Copy link
Contributor Author

It's a trap !

@ReinerBforartists
Copy link
Contributor Author

internals like Blenkernel has nothing to do with addons.

The error message does not show here though, i have recreated the icons, did a clean compile, and do not get these kind of errors. All works well. Clearing the cmake cache may help.

@Draise14
Copy link
Collaborator

Will recompile from scratch, good point.

@Draise14
Copy link
Collaborator

Draise14 commented Feb 1, 2024

Found the issue, was an old addon referencing icons the wrong way, by index instead of name.

@Draise14 Draise14 closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - task A normal development task 1- Fixed This task is fulfilled
Projects
None yet
Development

No branches or pull requests

3 participants