Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select color in edit mode with face select now grey instead of orange #3961

Closed
ReinerBforartists opened this issue Nov 27, 2023 · 20 comments
Closed
Assignees
Labels
1- Fixed This task is fulfilled 2 - bug It's a bug !! Please make sure that it really is ;)

Comments

@ReinerBforartists
Copy link
Contributor

Describe the bug

Selected face does not show selected orange color anymore. But grey. Needs a fix.

Desktop (please complete the following information):
Win 10

Screenshots, Example Files

selectcolor

@ReinerBforartists ReinerBforartists added the 2 - bug It's a bug !! Please make sure that it really is ;) label Nov 27, 2023
@ReinerBforartists
Copy link
Contributor Author

ReinerBforartists commented Nov 27, 2023

Hmm, it does not seem to be a theme problem. Switching to the Blender theme does not fix it. And the color in the theme fits.

facesel

@ReinerBforartists
Copy link
Contributor Author

It shows orange with vertices mode, with edge mode, but not with face mode. Looks like a problem in the code somewhere.

@ReinerBforartists ReinerBforartists changed the title Select color in edit mode now grey instead of orange Select color in edit mode with face select now grey instead of orange Nov 27, 2023
@esnosy
Copy link
Collaborator

esnosy commented Nov 27, 2023

hmm maybe this is related to the goo engine patch we applied a while ago, maybe it got killed by Blender changes

@Draise14
Copy link
Collaborator

I thought I fixed this. I'll check the commit logs now.

@ReinerBforartists
Copy link
Contributor Author

Friends, this is a showstopper that we need to fix ...

@Draise14
Copy link
Collaborator

It's a theme issue. Already fixed locally. I'm not at the computer till Sunday evening or Monday. But can do it then.

Did it make it into the official release?

@ReinerBforartists
Copy link
Contributor Author

ReinerBforartists commented Nov 30, 2023

Yes it has.

The devbuild from 04-11-2023 did work fine. Everything behind this point is broken it seems. Devbuild from 10-11-2023 already shows the problem.

@Draise14
Copy link
Collaborator

Draise14 commented Dec 5, 2023

Will work this this afternoon, it is kinda annoying changing this often every new compile, so yeah. High priority.

Would this be worth a 4.0.2 release?

@ReinerBforartists
Copy link
Contributor Author

Your decision :)

@ReinerBforartists
Copy link
Contributor Author

Meow?

Users becomes impatient ^^

@esnosy
Copy link
Collaborator

esnosy commented Dec 6, 2023 via email

@ReinerBforartists
Copy link
Contributor Author

@Draise14 said it is a theming issue. And that it is fixed at his end already. So i basically wait for the commit. And the decision if we make a point release since this is a showstopper bug.

@Draise14 Draise14 self-assigned this Dec 6, 2023
@Draise14
Copy link
Collaborator

Draise14 commented Dec 6, 2023

Will do this after commit logs. Work has been crazy since coming back from the BCON, I'm 2 weeks behind absolutely everything.

I'm not sure about a new release yet, though it might be more stable. 4.0 was a lot buggier than the current 4.1 right now.

@ReinerBforartists
Copy link
Contributor Author

Don't you love the time before christmas ^^

@Draise14
Copy link
Collaborator

Draise14 commented Dec 6, 2023

I do not love the time before Christmas... 😂

@Draise14
Copy link
Collaborator

Draise14 commented Dec 6, 2023

Mode Face Selected is an additional layer of selection coloring when NOT in face selection mode. So it's easier to see what mode you're in (edge or vertex, though full face is selected). So as a UX, I think active and selected faces in face mode is typical orange and when in edge and vertex mode, selected faces is now the optional "selected" colour from the outliner, a blue, which allows to see edge and vertex selection better.

Updates:

  • I made the edge/vertex/face active vs selected same colours
  • Made the the edge and vertex face sub-selection a blue (like the outliner active vs selected) colours.
bforartists_i9x0vG7uuq.mp4

@Draise14
Copy link
Collaborator

Draise14 commented Dec 6, 2023

Pushed to master.

@Draise14
Copy link
Collaborator

Draise14 commented Dec 6, 2023

Not sure if worth updating every single screen capture with mesh selection in the documentation ...? Should I take that monumental task?

@Draise14 Draise14 added question 1- Fixed This task is fulfilled labels Dec 6, 2023
@ReinerBforartists
Copy link
Contributor Author

Make it a task in the manual :)

@Draise14
Copy link
Collaborator

Draise14 commented Dec 6, 2023

Righteo.

@Draise14 Draise14 closed this as completed Dec 6, 2023
@Draise14 Draise14 removed the question label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1- Fixed This task is fulfilled 2 - bug It's a bug !! Please make sure that it really is ;)
Projects
None yet
Development

No branches or pull requests

3 participants