Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pymoose.yml to run for python3.11 and 3.12 #469

Closed
wants to merge 2 commits into from
Closed

Conversation

hrani
Copy link
Contributor

@hrani hrani commented Feb 19, 2024

No description provided.

Copy link
Collaborator

@subhacom subhacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Python 3.7 reached end of life (https://devguide.python.org/versions/) and 3.8 is about to reach the same this year, let us remove those two. Also 3.10 is within quotes while the others are not. Let us put all of them within quotes for consistency if that is correct.

@subhacom
Copy link
Collaborator

The workflow may need to be updated:

  1. Python 3.7 and 3.8 can be removed.
  2. Instead of python setup.py install as per https://packaging.python.org/en/latest/tutorials/packaging-projects/, one should use python -m pip install --upgrade build and then python -m build. If not packaging, simply pip install . can also work.

@hrani hrani closed this Mar 8, 2024
@hrani
Copy link
Contributor Author

hrani commented Mar 8, 2024

Fixed in commit ba12ae3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants