Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added empty list check #61

Merged
merged 2 commits into from
May 27, 2023
Merged

Added empty list check #61

merged 2 commits into from
May 27, 2023

Conversation

nalin-singh
Copy link
Contributor

No description provided.

Copy link
Owner

@Bhupesh-V Bhupesh-V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a minor suggestion

ugit Outdated
)

[[ "$LOST_STASH" ]] && read -p "Enter Stash Description: " -r STASH_MSG || exit
if [ -z "$LOST_STASH" ]; then
echo "No unreachable commits found. Exiting..."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use printf, to be consistent acorss the codebase

Suggested change
echo "No unreachable commits found. Exiting..."
printf "%s\n" "No unreachable commits found. Exiting..."

@Bhupesh-V Bhupesh-V merged commit 6db2f6b into Bhupesh-V:master May 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants