Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare labels #22

Merged
merged 26 commits into from
Nov 14, 2021
Merged

Compare labels #22

merged 26 commits into from
Nov 14, 2021

Conversation

jo-mueller
Copy link
Contributor

Description

I added a method to compare labels between two label images label_image_x and label_image_y. The difference between the images is quantified in terms of Jaccard score and Dice score. The jaccard_score uses the function implemented in scikit-learn, the dice score is derived from the Jaccard-score as described in Wikipedia.

I added a notebook that visualizes the label-wise differences based on example data that is already shipped with biapol_utilities. Tests are included.

Type of change

  • Bug-fix
  • New feature
  • Breaking change
  • Documentation update

References

Related to #17

Tests

  • I adapted existing tests, because
  • I added new tests to cover the code change
  • All tests pass with my change

Final checks

  • My change is the minimal possible work for the desired feature/fix
  • I updated the documentation where necessary to cover the change

@jo-mueller jo-mueller self-assigned this Nov 12, 2021
Copy link
Member

@haesleinhuepf haesleinhuepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Johannes @jo-mueller ,

just some minor comments.

Otherwise it looks great and you're welcome to go ahead and merge.

biapol_utilities/label/_compare_labels.py Outdated Show resolved Hide resolved
biapol_utilities/label/_compare_labels.py Outdated Show resolved Hide resolved
biapol_utilities/label/_compare_labels.py Outdated Show resolved Hide resolved
biapol_utilities/label/_compare_labels.py Outdated Show resolved Hide resolved
biapol_utilities/label/_compare_labels.py Outdated Show resolved Hide resolved
biapol_utilities/label/_compare_labels.py Show resolved Hide resolved
biapol_utilities/label/_compare_labels.py Outdated Show resolved Hide resolved
biapol_utilities/label/_compare_labels.py Outdated Show resolved Hide resolved
jo-mueller and others added 10 commits November 14, 2021 14:02
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
@jo-mueller jo-mueller merged commit 8da21a7 into main Nov 14, 2021
@jo-mueller jo-mueller deleted the compare-labels branch November 14, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants