-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare labels #22
Merged
Merged
Compare labels #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added labelwise jaccard-measurement and a label comparison function which should calculate more labels in future versions.
This reverts commit e9bfab7.
haesleinhuepf
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Johannes @jo-mueller ,
just some minor comments.
Otherwise it looks great and you're welcome to go ahead and merge.
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
…lities into compare-labels
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a method to compare labels between two label images label_image_x and label_image_y. The difference between the images is quantified in terms of Jaccard score and Dice score. The jaccard_score uses the function implemented in scikit-learn, the dice score is derived from the Jaccard-score as described in Wikipedia.
I added a notebook that visualizes the label-wise differences based on example data that is already shipped with biapol_utilities. Tests are included.
Type of change
References
Related to #17
Tests
Final checks