Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update links in the readme #27

Merged
merged 1 commit into from
Nov 30, 2021
Merged

update links in the readme #27

merged 1 commit into from
Nov 30, 2021

Conversation

haesleinhuepf
Copy link
Member

@haesleinhuepf haesleinhuepf commented Nov 30, 2021

Description

Hi Johannes @jo-mueller ,

I'm just sending an edit of the readme for your review. I remove two links which were not really related to this project and updated the others in a way so that they appear as internet links where people can click on.

Let me know what you think!

Type of change

  • Bug-fix
  • New feature
  • Breaking change
  • Documentation update

References

Tests

  • I adapted existing tests, because
  • I added new tests to cover the code change
  • All tests pass with my change

Final checks

  • My change is the minimal possible work for the desired feature/fix
  • I updated the documentation where necessary to cover the change
  • I rebuilt the documentation page to document the change, if necessary

@jo-mueller
Copy link
Contributor

No objections from my side. Feel free to merge.

@haesleinhuepf haesleinhuepf merged commit 2ae2846 into main Nov 30, 2021
@haesleinhuepf haesleinhuepf deleted the haesleinhuepf-patch-1 branch November 30, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants