Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building doc pages to separate branch #31

Merged
merged 11 commits into from
Dec 20, 2021
Merged

Conversation

jo-mueller
Copy link
Contributor

Description

This PR introduces a github action which automatically builds documentation files into a separate branch (gh-pages) and adds all doc files (.html and .doctree) to the list of ignored files. Hence, the long list of deleted files further down. Doing it this way has the big advantage that we will not have to meddle with comparing doc files in future pull requests.

I tested it on a separate fork and it works. The new workflow for PR requests would thus be:

  • Make some change to the code
  • Run sphinx locally to check that the documentation builds properly
  • merge change to main.
  • Doc files are automatically built and pushed to gh-pages, which serves as source page for biapol.github.io/biapol-utilities

I pointed to this workflow in the changed PR template and in the Contribute section on the homepage..

Let me know what you think :)

Type of change

  • Bug-fix
  • New feature
  • Breaking change
  • Documentation update

References

Fixes #29

Tests

  • I adapted existing tests, because
  • I added new tests to cover the code change
  • All tests pass with my change

Final checks

  • My change is the minimal possible work for the desired feature/fix
  • I updated the documentation where necessary to cover the change
  • I rebuilt the documentation page to document the change, if necessary

@jo-mueller
Copy link
Contributor Author

The remaining conflicts come exactly from documentation files, so I would think that it makes sense to just use the changes from the incoming branch.

Copy link
Member

@haesleinhuepf haesleinhuepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@zoccoler zoccoler added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 20, 2021
Copy link
Contributor

@zoccoler zoccoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea!
I will try using this soon to add something.

@jo-mueller jo-mueller merged commit d7ee767 into BiAPoL:main Dec 20, 2021
@jo-mueller jo-mueller mentioned this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build documentation into a different branch
3 participants