Word-align wav total audio length to correctly parse metadata (#1152)

* Word-align wav total audio length to correctly parse metadata * word-align audio data, so it's size is never an odd number * removed constant
Bible-Translation-Tools · Jun 6, 2024 · 9eb5a9d · 9eb5a9d
1 parent 973d14f
commit 9eb5a9d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/common/audio/build.gradle b/common/audio/build.gradle
@@ -1,5 +1,5 @@
 group = 'org.wycliffeassociates.otter.common'
-version = '0.4.2'
+version = '0.4.3'
 
 dependencies {
     testImplementation "junit:junit:$junitVer"

diff --git a/common/audio/src/main/kotlin/org/wycliffeassociates/otter/common/audio/wav/WavFile.kt b/common/audio/src/main/kotlin/org/wycliffeassociates/otter/common/audio/wav/WavFile.kt
@@ -162,7 +162,7 @@ class WavFile private constructor() : AudioFormatStrategy {
                 val metadataSize = totalDataLength - nonMetadataSize
                 val bytes = ByteArray(metadataSize)
                 file.inputStream().use {
-                    val metadataStart = headerSize + totalAudioLength
+                    val metadataStart = headerSize + wordAlign(totalAudioLength)
                     it.skip(metadataStart.toLong())
                     it.read(bytes)
                 }

diff --git a/common/audio/src/test/kotlin/org/wycliffeassociates/otter/common/audio/wav/CueChunkTest.kt b/common/audio/src/test/kotlin/org/wycliffeassociates/otter/common/audio/wav/CueChunkTest.kt
@@ -89,7 +89,7 @@ class CueChunkTest {
                 }
                 val os = WavOutputStream(wav)
                 os.use {
-                    os.write(ByteArray(writeSize))
+                    os.write(ByteArray(wordAlign(writeSize)))
                 }
                 val validator = WavFile(file, WavMetadata(listOf(CueChunk())))
                 val resultMetadata = validator.metadata