Save and quit before navigating home from marker app (OT-884)

[darrellcolehill]

This change is 

[AnonymousWalker]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @darrellcolehill and @jsarabia)

---

jvm/workbookapp/src/main/kotlin/org/wycliffeassociates/otter/jvm/workbookapp/ui/NavigationMediator.kt line 104 at r1 (raw file):

                val homePage = find<HomePage2>()
                fire(NavigationRequestEvent(homePage))
                NavigationRequestEvent(homePage)

what's this line for?

[darrellcolehill]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @AnonymousWalker and @jsarabia)

---

jvm/workbookapp/src/main/kotlin/org/wycliffeassociates/otter/jvm/workbookapp/ui/NavigationMediator.kt line 104 at r1 (raw file):

Previously, AnonymousWalker (Tony) wrote…

what's this line for?

Thanks for catching that! I am not sure why that is there.

[jsarabia]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @AnonymousWalker)

[AnonymousWalker]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @darrellcolehill)

---

jvm/markerapp/src/main/kotlin/org/wycliffeassociates/otter/jvm/markerapp/app/view/MarkerView.kt line 72 at r2 (raw file):

        }

        subscribe<NavigationRequestBlockedEvent> {

Would it be possible to use the existing PluginCloseRequestEvent approach? I believe marker app is also a "plugin" and we have solved a similar problem using that event.

[darrellcolehill]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @AnonymousWalker)

---

jvm/markerapp/src/main/kotlin/org/wycliffeassociates/otter/jvm/markerapp/app/view/MarkerView.kt line 72 at r2 (raw file):

Previously, AnonymousWalker (Tony) wrote…

Would it be possible to use the existing PluginCloseRequestEvent approach? I believe marker app is also a "plugin" and we have solved a similar problem using that event.

The issue I was having with that was with coordinating the narration view model since it is still docked. Are you thinking of firing the PluginClosRequestEvent on home button click when the marker app is open?

[darrellcolehill]

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @AnonymousWalker)

---

jvm/workbookapp/src/main/kotlin/org/wycliffeassociates/otter/jvm/workbookapp/ui/narration/NarrationViewModel.kt line 182 at r3 (raw file):

                }
            } else if (pluginOpenedProperty.value) {
                navigator.navigateHomeOnPluginClosed = true

@AnonymousWalker This could be modified by doing the following:

1. Move navigateHomeOnPluginClosed from the navigator, to NarrationViewModel
2. Allow PluginClosedEvent to take in an optional parameter named something like "naviateHome" that has a default value of false
3. Have the navigator's subscription to PluginClosedEvent navigate home when navigateHome == true
4. Pass the value of navigateHome when firing PluginClosedEvent in onChapterReturnFromPlugin

I am not crazy about adding another Boolean in the NarrationViewModel, but the above steps seem more in line with what we discussed earlier.

[AnonymousWalker]

Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @darrellcolehill and @jsarabia)

---

jvm/workbookapp/src/main/kotlin/org/wycliffeassociates/otter/jvm/workbookapp/ui/narration/NarrationViewModel.kt line 186 at r4 (raw file):

        subscribe<NavigationRequestEvent>() {
            if (it.view == find<HomePage2>() && pluginOpenedProperty.value) {

could we do it.view is HomePage2 instead?

[jsarabia]

Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @AnonymousWalker and @darrellcolehill)