Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #1151

Merged
merged 89 commits into from
Jun 12, 2024
Merged

Dark mode #1151

merged 89 commits into from
Jun 12, 2024

Conversation

darrellcolehill
Copy link
Collaborator

@darrellcolehill darrellcolehill commented Jun 3, 2024

This change is Reviewable

Sets correct color for blue text in "New Project / Start" and "Consume and Verbalize / Start"
* Fixed background color
* Removed button borders
* Fixed icon colors
* Fixed button text colors
* Removed unnecessary styles in app-bar.css
* Fixed background color for translation cards
* Added borders around non active translation cards
* Fixed text/icon colors
* Gave it a rounded border
* Updated the header background
* Increased border width to 2px
* Updated border color
* Added more styles for btn--icon--primary.
* Made border size constant for enabled/disabled states
* Increased border size to 2px
* Updated background color on hover
* Updated selected background color
* Updated background color and icon color
* Updated borders for play, trash and select buttons
* Updated background color for slider
* Updated thumb color
* Updated background color to be -wa-foreground instead of gradient
* Removed border between markers
* Made pause button text visible in dark mode
* Added default text file to btn--icon--secondary
* Made save and cancel buttons use the btn--icon--secondary class instead of btn--secondary
* Added consume__btn--secondary class to account for blue text/border around save button
* Updated text, border, and icon color.
* Updated style class to marker-waveform
* Used MarkersContainer instead of MarkerTrackControl
* Sets canDeleteMarkerProperty to false
* Added strokes around highlights back in
* Updated MarkerView to use MarkerWaveform and not MarkerPlacementWaveform
* Updated selected and hover styles
Modified stylesheet imports based on imports from Translation. This is because the topTrack line only became visible when I opened the Translation page, then came back to the Marker App.
* Prior to this, the marker node's title-section was overflowing into the the border for the waveform. This was very noticeable in dark mode
@darrellcolehill darrellcolehill marked this pull request as ready for review June 4, 2024 12:19
@jsarabia jsarabia merged commit 3ca0dfe into dev Jun 12, 2024
9 of 10 checks passed
@jsarabia jsarabia deleted the dh-dark-mode branch June 12, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants