Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter grid snap scroll (OT-896) #1155

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Conversation

darrellcolehill
Copy link
Collaborator

@darrellcolehill darrellcolehill commented Jun 17, 2024

Scrolls selected chapter to the top of the chapter grid scroll pane.


This change is Reviewable

Copy link
Collaborator Author

@darrellcolehill darrellcolehill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions


jvm/controls/src/main/kotlin/org/wycliffeassociates/otter/jvm/controls/chapterselector/ChapterGrid.kt line 47 at r1 (raw file):

    fun getSelectedChapter(): Node? {
        val selectedChapterIndex = this.list.indexOfFirst { it.selected }

Not crazy about this. I tried lookupAll(":selected).firstOrNull() but was not getting the node I needed.


jvm/workbookapp/src/main/kotlin/org/wycliffeassociates/otter/jvm/workbookapp/ui/components/popup/ChapterSelectorPopup.kt line 82 at r1 (raw file):

    init {
        control.showingProperty().onChangeWithDisposer {

Not sure if having this in the skin is appropriate and how I would dispose of the listener.

@darrellcolehill darrellcolehill marked this pull request as ready for review June 17, 2024 19:35
@jsarabia jsarabia merged commit f3a1375 into dev Jun 24, 2024
9 of 10 checks passed
@jsarabia jsarabia deleted the dh-chapter-grid-snap-scroll-OT-896 branch June 24, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants