New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage #580
Code coverage #580
Conversation
65832ea
to
813f579
Compare
813f579
to
9a2927c
Compare
6fb99f4
to
463425d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 3 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AnonymousWalker and @jsarabia)
build.gradle
line 30 at r4 (raw file):
jacoco { toolVersion = "0.8.7" // use this jacoco version to avoid error
Please move the version number to dependencies.gradle file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @jsarabia and @mXaln)
build.gradle
line 30 at r4 (raw file):
Previously, mXaln (Maxim) wrote…
Please move the version number to dependencies.gradle file
Thanks for reminding!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @mXaln)
build.gradle
line 30 at r4 (raw file):
Previously, AnonymousWalker (Tony) wrote…
Thanks for reminding!
could this be placed under the allprojects block, instead of here and in the subprojects block?
As sonarqube only reads and analyzes from code coverage report file (.xml is best option), we need the
jacoco
java plugin to generate coverage report at project level.To aggregate the reports from subprojects, a custom
JacocoReport
task at root gradle file is needed to iterates through the project tree and collect the .exec file generated fromjacoco
plugin.Also, this report task should execute after running all the tests.
Helpful resources:
Github issue 8881
Gradle documentation
This change is