New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring development branch up to date with master #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the reference to the JCEF32 library, and move the required JCEF jars directly into the libraries folder
even if this commit is partial, I need to push so that I can continue working from my home computer during the weekend. Note that OptionsFrame.java is still in the works, especially the javascript portion of the preview document, I'm still formatting it (borrowed from the Word add-in vb.net script). I also staretd creating LocalizedBibleBooks.java but it is also incomplete!
For Java 1.8 we can use Apache Derby 10.14, it seems that 10.15 requires Java 1.9 which however is only 64bit. On Windows at least we need Java 1.8 32 bit so let's stick with Apache Derby 10.14, downloaded from here: https://downloads.apache.org/db/derby/db-derby-10.14.2.0/
JohnRDOrazio
added a commit
that referenced
this pull request
Oct 22, 2020
Merge pull request #9 from BibleGet-I-O/master
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue development that was being done on JCEF branch, in the development branch, now that things are starting to be in place and starting to behave nicely