Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quake 3 Arena parser + fix for OpenArena parser #369

Merged
merged 5 commits into from Jan 29, 2018

Conversation

lrq3000
Copy link
Contributor

@lrq3000 lrq3000 commented May 29, 2017

This PR adds a Quake 3 Arena parser from the OpenArena one. Should fully support Quake 3 Arena. There might be some dead code in the parser (that are only useful to OpenArena), but I'm not sure what with the recent evolutions of ioquake3.

This PR also adds optional support for ExcessivePlus mod, for both Quake 3 Arena and OpenArena.

The parser is being tested right now on a production server, please wait one or two weeks before merging (in case I need to apply a fix).

Signed-off-by: Stephen L. <lrq3000@gmail.com>
Signed-off-by: Stephen L. <lrq3000@gmail.com>
Signed-off-by: Stephen L. <lrq3000@gmail.com>
@danielepantaleone
Copy link
Member

Hi there. Many thanks for this PR! I will wait until you tell me the code is stable and is available to be merged. Please do not consider Travis CI build status reporting the build as failed. Automated tests have not been updated in the last year and they won't be updated: I'm currently moving B3 source code to python 3.6 rewriting bits of the core structure (event loop, plugin structure, storage interface etc..) so I will provide automated tests for the new version (2.0??) as soon as the porting is completed (it's going to take some time though). 👍

lrq3000 and others added 2 commits June 2, 2017 02:55
Signed-off-by: Stephen L. <lrq3000@gmail.com>
@danielepantaleone danielepantaleone merged commit fc11fda into BigBrotherBot:master Jan 29, 2018
@lrq3000
Copy link
Contributor Author

lrq3000 commented Jan 29, 2018

Sorry missed your comment, but now I can confirm it works as intended, it has been running on several servers since then with no obvious issue :-) Thanks for merging!

@danielepantaleone
Copy link
Member

No worries. Sorry for being sooo late. I have been working on porting B3 to python 3.6 in the last months (which I'm still partially doing) and I completely forgot about this one.

@lrq3000
Copy link
Contributor Author

lrq3000 commented Jan 29, 2018

Ah that's great news! Yes Py3.6 is quite different, I have yet to port my own projects :p Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants