Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "What's next" on LiveTV Fullscreeninfo #710

Conversation

walterheisenberg2
Copy link

info on LiveTV:
"up" switches between "FullPlot" and small "PlotOutline"
"left/right" switches between "actual" and "Next"-Plot-info

info on LiveTV:
"up" switches between "FullPlot" and small "PlotOutline"
"left/right" switches between "actual" and "Next"-Plot-info
Copy link
Owner

@BigNoid BigNoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor comments.

<height>650</height>
<width>1805</width>
<itemgap>10</itemgap>
<height>750</height>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double height tag

<height>650</height>
<width>1805</width>
<itemgap>10</itemgap>
<height>750</height>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double height tag

@walterheisenberg2
Copy link
Author

I'll correct that later
Thx for the hint

FYI: Other PR that you merged:
you don't see any difference between Plot and PlotOutline in LiveTV-democlient
PlotOutline in "real" TV has e.g. the episodename and the year

- removed a double height-tag
- fixed a bug where Plot is shown, when small PlotOutline is enabled
@walterheisenberg
Copy link
Contributor

walterheisenberg commented Oct 12, 2016

Please have a look again.

Edit: Sorry, wrong username. I needed 2 usernames, because I couldn't fork your skin while SiLVOs was in my repo.

@BigNoid BigNoid merged commit 21e9eca into BigNoid:master Oct 18, 2016
@BigNoid
Copy link
Owner

BigNoid commented Oct 18, 2016

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants