Added support for <propertypattern> #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bambi73
force-pushed
the
custom-properties-pattern
branch
from
16bba4f
to
bf5636b
Compare
| propertyGroup = propertyPatternElement.get("group") | ||
|
|
||
| if propertyName and propertyGroup and propertyPatternElement.text: | ||
| if propertyGroup == group: |
There was a problem hiding this comment.
would be nice you would do "if not ...: continue" instead of super-deep nesting :)
|
looks fine apart from cosmetics (I prefer to use continue instead of deep nesting of conditionals) |
bambi73
force-pushed
the
custom-properties-pattern
branch
from
bf5636b
to
e4b8f64
Compare
|
Reversed conditions and added continue to remove some nesting |
|
thx. |
BigNoid
added a commit
that referenced
this pull request
Jun 2, 2015
Added support for <propertypattern>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for custom shortcut properties patterns.
Feature is described in Advanced Usage.txt point 14.