Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template and additional submenu improvements #201

Merged
4 commits merged into from Nov 9, 2016
Merged

Template and additional submenu improvements #201

4 commits merged into from Nov 9, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 5, 2016

Submenu templates:-

  • Add 'sub templates' which build for each item in the submenu and can then be inserted into the primary submenu template which is built just once for each submenu.

Additional submenus:-

  • Add ability for skin to indicate that the additional submenu levels shouldn't be shared between skins (this allows me to use them in a way that won't be compatible with other skins)
  • Various fixes related to additional submenu's, most notably corrects a bug where the .DATA.xml and the associated properties wouldn't be copied from skin defaults when first editing the menu

@marcelveldt I've included a 'Mark stable' commit in this as I'd like to get this onto the repo sooner than later as I'm already using these features. Would you prefer to go through a public test first? If so, I'll remove that commit.

@ghost
Copy link
Author

ghost commented Nov 9, 2016

As there seems to be no objection I'm going to merge this now and look at a repo push later today. If there are any issues with this, there's normally at least a couple of days to cancel the repo update request.

@ghost ghost merged commit a16c0f5 into BigNoid:master Nov 9, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant