Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of code to generate 'list' property for shortcuts #26

Merged
merged 1 commit into from Jul 15, 2015
Merged

Rewrite of code to generate 'list' property for shortcuts #26

merged 1 commit into from Jul 15, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2015

Changes to code to generate 'list' property - supercedes #16, as discussed @14b215dd08

  • Cleaner code, splitting on commas to grab appropriate part of the shortcut
  • Only works for ActivateWindow shortcuts (other shortcuts will return as-is - let me know if there are any other shortcut types that should provide a specific 'list' property)
  • Moved to datafunctions.py (because I intend to use this for updated widget selection code, and because xmlfunctions has become out of control and code needs moving out of there!)

@marcelveldt - this is your feature, so can you please review to ensure I haven't broken the use case you originally added this for.
@HitcherUK and @Nessus85100 - both of you reported issues with the original code, so can you please test to ensure the code fixes any issues / does not introduce any new issues / there's no other obvious use-cases I should add whilst I'm working on the code.

Cheers.

@marcelveldt
Copy link
Contributor

@Ignoble61, It looks fine to me. Great thing too about changing the widget selection, that is something that is really wanted/needed.
atm I used a very complicated workaround for that in my skin, would be good if that could be replaced by this.

This request btw came from @HitcherUK Maybe he can tell us a little more about the use case he wants to use this list property for. I suspect it has something to do with choosing widget content. In that case the new widget selector would be even better.

marcelveldt added a commit that referenced this pull request Jul 15, 2015
Rewrite of code to generate 'list' property for shortcuts
@marcelveldt marcelveldt merged commit ffe403b into BigNoid:master Jul 15, 2015
@marcelveldt
Copy link
Contributor

code working fine on my testsetup

@ghost
Copy link
Author

ghost commented Jul 15, 2015

Thanks for testing + merging 👍

@ghost ghost deleted the list-property branch July 15, 2015 07:51
@Nessus85100
Copy link

Also everything working fine for me too. The missing bracket it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants