Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old functions #30

Merged
1 commit merged into from Aug 19, 2015
Merged

Remove old functions #30

1 commit merged into from Aug 19, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 18, 2015

Removes all .shortcut file compatibility (should only affect Nox5 + variants)
Removes ability for list to be filled with controls to launch management dialog (I don't believe these methods are in use by any skin)

@BigNoid - as these changes should only affect your skin + variants, do you want the honour of merging when you feel comfortable (idk if you prefer to wait for your change to .DATA.xml files - #22 - to hit the repo before this gets merged)?

@BigNoid
Copy link
Owner

BigNoid commented Jul 18, 2015

@Ignoble61 Thanks, I'll do a pull request shortly for Nox. If this change can wait till then it would be highly appreciated. I'll merge this then right after that.
I see removing the old functions saves quite a lot of code!

@ghost
Copy link
Author

ghost commented Jul 18, 2015

No rush at all for this getting merged from my pov. Just nice to be able to delete some of the old code ;)

@ghost
Copy link
Author

ghost commented Aug 1, 2015

Found one other skin from a quick repo search that also uses the .shortcuts files - would be nice if this didn't get merged until that skin has time to update to the new format as well :) (See skin.mimic issue referenced above)

@ghost ghost mentioned this pull request Aug 1, 2015
@marcelveldt
Copy link
Contributor

Mimic has changed the shortcuts method on your request so that's all fine now. As soon as BigNoid has published the update of his skin to the repo, this thing can be merged too, right ?

@ghost
Copy link
Author

ghost commented Aug 8, 2015

Right.

@BigNoid
Copy link
Owner

BigNoid commented Aug 18, 2015

This can be merged now, but must be rebased i think.

Removes all .shortcut file compatibility
Removes ability for list to be filled with controls to launch
management dialog
@ghost
Copy link
Author

ghost commented Aug 19, 2015

Rebased and merged, cheers.

ghost pushed a commit that referenced this pull request Aug 19, 2015
@ghost ghost merged commit d8e1552 into BigNoid:master Aug 19, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants