Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async actions preserve single array argument #14

Merged
merged 3 commits into from Jul 28, 2020
Merged

Async actions preserve single array argument #14

merged 3 commits into from Jul 28, 2020

Conversation

wswoodruff
Copy link
Contributor

Fixes #13
Wrote a check for single arg array as a special case, then wrote a test for it

@devinivy
Copy link
Contributor

devinivy commented Jul 27, 2020

Hey @wswoodruff could you do a few things here:

  • Update the PR title to briefly describe the change you implemented. You can probably just adapt the title from Async actions turn single array argument into multiple handler arguments #13.
  • Assign labels and get the milestone setup for the next minor version.
  • Move the code you wrote into a new test that also ensures the handler receives the correct arguments, which is the real thing that we want to fix. (Actually in a perfect world we would have been able to fix the handler arguments without changing the action payload, but for now these things are coupled.)

@wswoodruff wswoodruff changed the title Fix #13 Async actions preserve single array argument Jul 27, 2020
@wswoodruff wswoodruff added breaking changes bug Something isn't working and removed breaking changes labels Jul 28, 2020
Copy link
Contributor

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@devinivy devinivy self-assigned this Jul 28, 2020
@devinivy devinivy merged commit 332fd12 into BigRoomStudios:master Jul 28, 2020
@wswoodruff wswoodruff added this to the 0.4.0 milestone Jul 28, 2020
@wswoodruff wswoodruff deleted the fix-#13 branch July 28, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async actions turn single array argument into multiple handler arguments
2 participants