Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Prim Hierarchy Delegate and default prim / variant set features #21

Merged
merged 58 commits into from
Nov 29, 2023
Merged

Enhancement: Prim Hierarchy Delegate and default prim / variant set features #21

merged 58 commits into from
Nov 29, 2023

Commits on Nov 24, 2023

  1. Move prim type icon provider into its own file for re-use

    @BigRoy
    BigRoy committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    e70e372 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. Allow setting and clearing the root layer's default prim, move Create… 

    … Prim into menu of its own
    @BigRoy
    BigRoy committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    1f0b593 View commit details
    Browse the repository at this point in the history

  2. Move menus around

    @BigRoy
    BigRoy committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    8501e3b View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. When renaming prim only rename, when reparenting prim without name ch… 

    …ange only reparent

Fix #15
    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    94f793f View commit details
    Browse the repository at this point in the history

  2. Allow removing references/payloads from prim spec editor

    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    6229dda View commit details
    Browse the repository at this point in the history

  3. Remove early return

    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    c8c8926 View commit details
    Browse the repository at this point in the history

  4. Allow simple visualizing of default prim, references and variant sets… 

    … on Prim + allow to add reference or create variant set
    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    8a52e9c View commit details
    Browse the repository at this point in the history

  5. Allow adding a payload

    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    136ec65 View commit details
    Browse the repository at this point in the history

  6. Add some colors to references and payloads + show reference/payload t… 

    …ype name in Prim Spec Editor
    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    43775b2 View commit details
    Browse the repository at this point in the history

  7. Add tooltips to the drawn tags prims

    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    8b23cd2 View commit details
    Browse the repository at this point in the history

  8. Fix support for variant set specs

    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    6b36b02 View commit details
    Browse the repository at this point in the history

  9. Simplify readability of the filters

    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    db263ca View commit details
    Browse the repository at this point in the history

  10. Cosmetics

    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    3582444 View commit details
    Browse the repository at this point in the history

  11. Match contents margings with other widgets

    @BigRoy
    BigRoy committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f8cbe84 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Allow moving specs to another target layer 

    Note: If moved to a PrimSpec path already existing in the target layer then any opinions on that PrimSpec or it children are removed. It replaces the prim spec - it does not 'merge' it into an existing prim spec.

This is an implementation and thus fix for #20
    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    beb33bc View commit details
    Browse the repository at this point in the history

  2. Remove incorrect docstring

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9f65ae9 View commit details
    Browse the repository at this point in the history

  3. Connect context menu delete trigger

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9dfc5e4 View commit details
    Browse the repository at this point in the history

  4. Only apply delegate to first column explicitly

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    6bde305 View commit details
    Browse the repository at this point in the history

  5. Implement MapProxyItems for Prim Spec editor

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d80206e View commit details
    Browse the repository at this point in the history

  6. Add warning log for edge case; not sure when it happens yet

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    95a9466 View commit details
    Browse the repository at this point in the history

  7. Do not delete items that aren't copied specs on Move To Layer functio… 

    …nality
    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    244fb09 View commit details
    Browse the repository at this point in the history

  8. Use a monospace Courier font when displaying the ASCII output

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b4dd39c View commit details
    Browse the repository at this point in the history

  9. Use padding instead of margins for nicer row highlighting

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a855a26 View commit details
    Browse the repository at this point in the history

  10. Add docstring

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fbba0fd View commit details
    Browse the repository at this point in the history

  11. Allow layers to appear more than once, even when loading the same sub… 

    …layers across multiple parents that are also shared - make the key unique by the full parent layer stack to ensure uniqueness
    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f828535 View commit details
    Browse the repository at this point in the history

  12. Do not instantiate Usd.SchemaRegistry but call the functions as sta… 

    …tic equivalents

This fixes an issue where the first call to `get_prim_types_by_group` would send out a bunch of `pxr.Sdf.LayersDidChange` notices
    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    862453b View commit details
    Browse the repository at this point in the history

  13. Preserve relative scroll on updates

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1c8bf87 View commit details
    Browse the repository at this point in the history

  14. Refactor PySide2 usage to qtpy where relevant

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f947370 View commit details
    Browse the repository at this point in the history

  15. Implement draft UI for reference/payload lists

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    80c5737 View commit details
    Browse the repository at this point in the history

  16. Fix indentation on add buttons

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    14d9876 View commit details
    Browse the repository at this point in the history

  17. Add maximize/minimize buttons

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ea30c73 View commit details
    Browse the repository at this point in the history

  18. For now adopt OpenPype style together with embedding their LICENSE … 

    …in `usd_qtpy/style`

We might swap out the stylesheet later with something custom/simplified
    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a2567ba View commit details
    Browse the repository at this point in the history

  19. Merge remote-tracking branch 'origin/main' into enhancement/prim_hier… 

    …archy_delegate
    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    8f75f04 View commit details
    Browse the repository at this point in the history

  20. Do not inherit from QDialog because we don't want to close main edito… 

    …r on pressing ESC
    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1a64f0e View commit details
    Browse the repository at this point in the history

  21. Do not disconnect stage on layer editor hide and re-show panel

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    030b5fa View commit details
    Browse the repository at this point in the history

  22. Allow editing PrimSpec.specifier in Prim Spec editor

    @BigRoy
    BigRoy committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    4f5a3f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. List value types for Attribute Specs

    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    63213e6 View commit details
    Browse the repository at this point in the history

  2. Perform nicer - "move to layer" so that it doesn't completely replace… 

    … existing only children but instead merges next to existing children
    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0fbc6ec View commit details
    Browse the repository at this point in the history

  3. Use more icons + simplify icons access

    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    017b052 View commit details
    Browse the repository at this point in the history

  4. Show target prim in window title

    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    a13411e View commit details
    Browse the repository at this point in the history

  5. Fix return type

    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7e51ea3 View commit details
    Browse the repository at this point in the history

  6. Implement managing references/payloads

    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    260c38f View commit details
    Browse the repository at this point in the history

  7. Move ReferenceListWidget into its own file for readability and reusab… 

    …ility
    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    248be4d View commit details
    Browse the repository at this point in the history

  8. Cosmetics: move import to top

    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0f43761 View commit details
    Browse the repository at this point in the history

  9. Add Prim Path Picker + refactor some content around for Prim Hierarch… 

    …y re-use
    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e4c331b View commit details
    Browse the repository at this point in the history

  10. Fix setting current prim path + remove debug print

    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ca7ebcf View commit details
    Browse the repository at this point in the history

  11. Show root layer display name in editor window title

    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2910797 View commit details
    Browse the repository at this point in the history

  12. Chore: start refactoring variants logic into its own package

    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    9a59773 View commit details
    Browse the repository at this point in the history

  13. Do not log the full layer exported to string

    @BigRoy
    BigRoy committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    cd361a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Fix Prim Hierarchy refreshing 

    Note: The view now also shows the pseudoroot - it's up for discussion whether that's preferred or not
    @BigRoy
    BigRoy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f7c742e View commit details
    Browse the repository at this point in the history

  2. For now hide the pseudoroot prim again

    @BigRoy
    BigRoy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    fa78f62 View commit details
    Browse the repository at this point in the history

  3. Revert quick hack to avoid / pseudoroot since it'd basically break on… 

    … a model reset
    @BigRoy
    BigRoy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    07f12c9 View commit details
    Browse the repository at this point in the history

  4. Fix full resyncs (e.g. on layer muting) + remove layer listener since… 

    … it was running to early and the bug was actually in teh filtering of resynced paths on objects changed
    @BigRoy
    BigRoy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    85e0b59 View commit details
    Browse the repository at this point in the history

  5. Simplify check

    @BigRoy
    BigRoy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    680b1b5 View commit details
    Browse the repository at this point in the history

  6. Simplify logic, call prim.GetPath() once

    @BigRoy
    BigRoy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f7235b0 View commit details
    Browse the repository at this point in the history

  7. Chore: Code cleanup

    @BigRoy
    BigRoy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    08f8e1a View commit details
    Browse the repository at this point in the history

  8. Use monospace font from stylesheet using a custom property

    @BigRoy
    BigRoy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    936c6c8 View commit details
    Browse the repository at this point in the history

  9. Add screenshot of editor to README.md

    @BigRoy
    BigRoy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    fb2708e View commit details
    Browse the repository at this point in the history