Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on CRAN? #3

Closed
eblondel opened this issue Dec 7, 2021 · 9 comments
Closed

Release on CRAN? #3

eblondel opened this issue Dec 7, 2021 · 9 comments

Comments

@eblondel
Copy link
Collaborator

eblondel commented Dec 7, 2021

Hi @btupper, do you have a plan to release 'thredds' package on CRAN?
I make use of 'thredds' package in the geoflow (https://github.com/eblondel/geoflow) R package, that i'm working with a plan to release on CRAN. Unfortunately, all dependencies should be part of CRAN for that.
If I can be of help, let me know.

Cheers
Emmanuel

@btupper
Copy link
Member

btupper commented Dec 8, 2021

Ahoy @eblondel,

I'm fine with pushing it along to CRAN, but I don't have the experience to make it a quick process nor the time to gain that experience that old-fashioned way. How about we coauthor, you make the necessary changes and push to CRAN as the maintainer? I'm not going away soon and still very much depend upon thredds, so I can assist in maintenance as needed.

Does that work for you?

PS geoflow looks very good!

@eblondel
Copy link
Collaborator Author

eblondel commented Dec 8, 2021

Hi @btupper thanks for your quick reply. I've some experiences with CRAN since i have several packages going there. Many thanks for your proposal for co-autoring, and suggest to be the maintainer i'm very grateful for this proposal. I will fork the repo and start checking what we miss for pushing into CRAN!

Another aspect that we could set is the integration tests, for which we could run some tests over known TDS servers, and maybe try to do it on a brand new TDS server if we can get to have it with sample data. Integration tests help to consolidate the code; I've now some experience on the work i did on another packages, I'll try to see for a similar approach for 'thredds'.

Thanks again
Emmanuel

PS: thanks for geoflow! :-) if you come to test/use it, feel free to contact me in case you need support

@eblondel
Copy link
Collaborator Author

eblondel commented Feb 3, 2022

Hi @btupper hope everything is fine. I've been restarting tests on thredds, and i'm going to do some minor adjustments to the package (including adding some Rdoc examples, etc). When ready I will commit everything here, and then I think we could attempt a submission to CRAN.

I'd like to configure some continuous integration tests (using the Github CI Actions), but i'm not sure I can do that, without direct rights to manage the repo. If this is not possible, I may start preparing the CI actions config for tests, and then I will need some interaction with you to enable the action. I'm not sure that the CRAN submission will pass if we don't configure some tests.

@btupper
Copy link
Member

btupper commented Feb 3, 2022

I just made you an administrator - that was easy! Great to hear about your progress.

eblondel added a commit that referenced this issue Feb 6, 2022
eblondel added a commit that referenced this issue Feb 6, 2022
eblondel added a commit that referenced this issue Feb 6, 2022
eblondel added a commit that referenced this issue Feb 6, 2022
eblondel added a commit that referenced this issue Feb 6, 2022
eblondel added a commit that referenced this issue Feb 6, 2022
eblondel added a commit that referenced this issue Feb 6, 2022
eblondel added a commit that referenced this issue Feb 6, 2022
eblondel added a commit that referenced this issue Feb 6, 2022
@eblondel
Copy link
Collaborator Author

eblondel commented Feb 7, 2022

Hi @btupper i've submitted first version to CRAN. They only asked me to fix the format of LICENSE file, so I assume the 2d submission I did with the fix will succeed. I'll let you know as soon I get their confirmation.
I'd suggest that we create a DOI for this. As good practice, this is how I tend to manage a R package:
1/ Publish on CRAN
2/ Create a release on Github, that is aligned with the CRAN publication
3/ Create a DOI
For DOIs, I use the Zenodo plateform that is open, and also allows for having versioned DOis, and a generic DOI that will always refer to the latest version of the package.
What do you think? Would it be ok to proceed in that way for 'thredds'?
Cheers

@btupper
Copy link
Member

btupper commented Feb 7, 2022

Hi @eblondel, that sounds like a good plan to me. I'm so glad to see your progress.

@eblondel
Copy link
Collaborator Author

eblondel commented Feb 9, 2022

Good news, it's on way to CRAN :-)
I've created a tag on Github, and set-up a DOI for the package at https://doi.org/10.5281/zenodo.6027224 In case you want me to refine metadata description attached to this DOI, let me know as even if published, metadata is editable.

@eblondel
Copy link
Collaborator Author

eblondel commented Feb 9, 2022

@btupper
Copy link
Member

btupper commented Feb 9, 2022

Congratulations and well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants