Skip to content
This repository has been archived by the owner on Jan 14, 2023. It is now read-only.

Close function doesn't remove full youtube ... #1

Closed
gr1298 opened this issue Aug 5, 2017 · 7 comments
Closed

Close function doesn't remove full youtube ... #1

gr1298 opened this issue Aug 5, 2017 · 7 comments
Assignees
Labels

Comments

@gr1298
Copy link

gr1298 commented Aug 5, 2017

Hi, should be used:
$('#alb_overlay').fadeOut(settings.effectTime, function(){$(this).remove();});
instead of
$('#alb_overlay').fadeOut(settings.effectTime);
already in use?
I asked that because i didn't have my youtube object full removed as the overlay window get closed but I still have the sound continuing....

@Bikossor
Copy link
Owner

Bikossor commented Aug 5, 2017

I'll check that out! Thanks for the note :D

@Bikossor Bikossor self-assigned this Aug 5, 2017
@Bikossor
Copy link
Owner

Bikossor commented Aug 5, 2017

I can't really recreate this problem, but I saw that the source files are not correct either.. I fixed up the source code. Maybe you can try this again 😃

Bikossor added a commit that referenced this issue Aug 5, 2017
@Bikossor Bikossor added the bug label Aug 5, 2017
@gr1298
Copy link
Author

gr1298 commented Aug 5, 2017

Hi, to reproduce my problem: after you open your youtube lightbox, just click on play button and let it start, so as you here a song just click in the "X" to close the lightbox window and I am getting it the lightbox window closed but the audio still there and if you reopen the lightbox window well the audio disappear.... but if you use a new youtube window well you have the same problem keeping going, well I tried remove and didn't work properly so i tried empty but it doesn't let me reopen completely, so is up to you

@Bikossor
Copy link
Owner

Bikossor commented Aug 5, 2017

I just testet it on Google Chrome and it behaved the way you described it. I'll take care of this problem. Did you use Chrome as well?

@gr1298
Copy link
Author

gr1298 commented Aug 5, 2017

Yes on chrome and also on Edge

@Bikossor
Copy link
Owner

Bikossor commented Aug 6, 2017

Okay NOW it's fixed. I also had to change some other parts from ES6 to ES5 because the IE isn't really compatible with it...

Bikossor added a commit that referenced this issue Aug 6, 2017
- Fixed issue #1
- Changed some lines from ES6 to ES5 *(For compatibility reasons)*
- The ``close``-Function now resets the ALightBox content explicitly
- Added a minified version of the stylesheet
@Bikossor
Copy link
Owner

Bikossor commented Aug 6, 2017

Does it work for you now?

@Bikossor Bikossor closed this as completed Aug 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants