Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Feedback - WillPopScope usage in other forms solved by updating persistent-tab-view.widget.dart to use NestedWillPopScope #156

Open
yashhema opened this issue Mar 31, 2021 · 0 comments

Comments

@yashhema
Copy link

Hello,
Our APP was using WillPopScope in large amount of places, recently we integrated the PersistentBottomNavBar, after integrating we found out the WillPopScope - call back function stopped firing.

I saw other peoples are also facing similar issue with the package and there are open issues.

On little bit digging , I updated the persistent-tab-view.widget.dart (from the package) to use NestedWillPopScope (https://gist.github.com/schultek/cc2acd8014be255c2a639a98d47be4e0) and also updated the other places in our app to use the same instead of WillPopScope, the call back function started working.

Just wanted to share my experience and if wanted to know , if you see potential drawback of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant