Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented NestedWillPopScope for later handling PopScopes #67

Closed
wants to merge 3 commits into from

Conversation

ne-ray
Copy link

@ne-ray ne-ray commented Oct 3, 2022

copy PR from BilalShahid13#221
autor by @PcolBP

I've implemented NestedWillPopScope with null-safety.
Separated so if later need to be used no need to implement all data from package just this file.
Updated dependency as well.

All behaviour from before stays the same.

Potential fixes of:

BilalShahid13#156
BilalShahid13#123

BilalShahid13#222

This PR contains no breaking change.

Implement NestedWillPopScope
Updated dependencies
Separate file to in nested widgets import only this one without other stuff
@ne-ray ne-ray closed this Nov 12, 2022
@ne-ray
Copy link
Author

ne-ray commented Nov 12, 2022

PR have conflict

@jb3rndt
Copy link
Owner

jb3rndt commented Nov 13, 2022

Is it still a feature you need? I was hesitant because I did not really understand why this is needed.

@ne-ray
Copy link
Author

ne-ray commented Nov 13, 2022

i thinked this PR fixing bug (issue - BilalShahid13/issues/123) , i tested this PR, but it isn't resolution :(

screencast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants