-
Notifications
You must be signed in to change notification settings - Fork 71
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
WinCon display : if we hit a 'dummy next to fullwidth' character, we …
…skip it and end the packet, restarting at the next character location. This ensures that the column will advance correctly, both in Win10 and Win11 (where a fullwidth character advances by two columns by default) or in older forks of Windows (where all characters advance by one column, no matter what).
- Loading branch information
Showing
1 changed file
with
18 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fac87bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems relevant for HISTORY.md, no?
fac87bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt that it fell in the general category of 'WinCon: supports full Unicode output including SMP", and listed this commit under that bullet point in
HISTORY.md
. If I confirm that the combining character fix also works, I'll commit it and change that line to say "WinCon: supports full Unicode output including SMP, fullwidth characters, and combining characters".But I don't expect to say anything in
HISTORY.md
about the details of how we got those things to work. Generally speaking, comments on implementation details have gone into the commit messages (as here), or as comments within the code.fac87bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.