fix newterm functionality for vt platform

[okbob]

Move output_fd, input_fd to global space from opaque structure. These variables are necessary before this structure can be created and initialized (newterm can be called before initscr). Use input_fd instead stdin and fileno(input_fd) instead hardcoded STDIN (STDIN_FILENO).

[Bill-Gray]

Hmmm... maybe I'm missing something here (quite likely I am), but...

I set SP->opaque->input_fd after initscr() quite intentionally. The idea was that during initial setup, we need (on Windows and DOS) to get our input from the "real" terminal in order to get the screen size. After that, once SP->opaque->input_fd is set, we get our input from that source instead.

This does cause me to see one bug (fixed in commit 3a73630), and it also makes me see that in initscr.c, newterm() should be the "real" code; initscr() should call newterm( NULL, NULL, NULL), instead of newterm() calling initscr() and then setting the input/output fds.

[okbob]

po 30. 1. 2023 v 2:49 odesílatel Bill Gray ***@***.***> napsal:

Hmmm... maybe I'm missing something here (quite likely I am), but... I set SP->opaque->input_fd *after* initscr() quite intentionally. The idea was that during initial setup, we need (on Windows and DOS) to get our input from the "real" terminal in order to get the screen size. After that, once SP->opaque->input_fd is set, we get our input from that source instead. This does cause me to see one bug (fixed in commit 3a73630 <3a73630>), and it also makes me see that in initscr.c, newterm() should be the "real" code; initscr() should call newterm( NULL, NULL, NULL), instead of newterm() calling initscr() and then setting the input/output fds.

I see inconsistency in the ncurses doc. There is a sentence so initscr can be called after newterm, but inside initscr (lib_initscr.c) is the newterm function called with stdout, stdin arguments. newtwrm uses stdout, stdin when arguments are null. So effectively it is not sensible to call these functions together because initscr overwrite setting of newterm. terminal line setting is done in _nc_initscr function that is called from newterm function. For my purpose the used input stream should be correctly initialized, that means so in PDC_reset_prog_mod is correctly used input stream and assigned input buffer (setbuf is null). Question: setbuf( input_fd, NULL) should be moved to PDC_reset_prog_mode from PDC_scr_open

…

— Reply to this email directly, view it on GitHub <#276 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEFO4ZOXX5PZYZ3QI4TVIDWU4M23ANCNFSM6AAAAAAUIHY4YQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[GitMensch]

Why was this closed and empty-pushed from c318f0a?

[okbob]

út 7. 2. 2023 v 11:51 odesílatel Simon Sobisch ***@***.***> napsal:

Why was this closed and empty-pushed from c318f0a <c318f0a> ?

It was due my bad knowledge of git, I am sorry - I broken my local repository, and I had to resync it again I did new PR #278 Pavel —

…

Reply to this email directly, view it on GitHub <#276 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEFO44FAUHQPDXTI53CXF3WWISK7ANCNFSM6AAAAAAUIHY4YQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>