If you tried to use Alt-F (optimize along the line of variation) when…

… there wasn't a for-real least-squares solution, a NULL pointer was accessed and it would segfault. Now, you get an error message and no crash.
Bill-Gray · Mar 30, 2023 · 9588a5b · 9588a5b
1 parent 7cfe9f3
commit 9588a5b
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/findorb.cpp b/findorb.cpp
@@ -5207,12 +5207,18 @@ int main( int argc, const char **argv)
          case ALT_F:
             {
             extern double **eigenvects;
-            const double n_sigmas = improve_along_lov( orbit, curr_epoch,
+
+            if( eigenvects && eigenvects[0])
+               {
+               const double n_sigmas = improve_along_lov( orbit, curr_epoch,
                      eigenvects[0], n_orbit_params, n_obs, obs);
 
-            snprintf( message_to_user, sizeof( message_to_user),
+               snprintf( message_to_user, sizeof( message_to_user),
                                        "Adjusted by %f sigmas", n_sigmas);
-            update_element_display = 1;
+               update_element_display = 1;
+               }
+            else
+               strlcpy_error( message_to_user, "No LOV along which to improve");
             }
             break;
          case CTRL( 'D'):