Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conda and make compatibility fixes #40

Merged
merged 2 commits into from
Mar 24, 2023
Merged

conda and make compatibility fixes #40

merged 2 commits into from
Mar 24, 2023

Commits on Mar 17, 2023

  1. miscell.cpp: update conda PREFIX workaround

    @mjuric
    mjuric committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    44f00f9 View commit details
    Browse the repository at this point in the history

  2. rename getstrex.c to getstrex.cpp, compile it with $CXX 

    getstrex.c is a C file, and could be compiled with the C compiler. However,
the rest of the makefile is only set up for the C++ compiler (specifically,
the logic that builds CXX flags). Rather than build CFLAGS in exactly the
same way, we'll "promote" getstrex.c to C++.

Without this change, the makefile is broken with tools that externally set
CC and CFLAGS (e.g., conda-build).
    @mjuric
    mjuric committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    26ca430 View commit details
    Browse the repository at this point in the history