Prevent unexpected exit status 1 when deleting codecoverage metadata
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event unexpected exit status change when the file is not available.
|
Was just about to create an github issue for this exact problem. Nice fix. Any chance to get it merged asap? |
|
@fabiomassimo I submitted a pull request (#3) for this issue before checking to see if anyone else had fixed it. Your solution is far simpler than mine. I hope @BinaryBeard will merge one soon |
BinaryBeard
approved these changes
Feb 23, 2018
BinaryBeard
approved these changes
Feb 23, 2018
This was referenced Feb 23, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As very last step, this action implementation gently cleans everything after itself. Although, last script from
codecoverage.iotakes now care of this for us.The result of deleting something that is not there, because already cleaned, causes the return of exit status 1
How
I have added the
-foption to rm such that we can prevent a change in the exit status if the remove can not find any matching file to delete.