LIME-199: Add chart for progress. #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
DavidCharif
requested review from
nikita-remeslov,
dimapopovych and
anton-otroshchenko
as code owners
anton-otroshchenko
requested changes
Feb 28, 2024
Comment on lines
40
to
48
| type Data = { | ||
| labels: string[]; | ||
| datasets: { | ||
| label: string; | ||
| data: number[]; | ||
| backgroundColor: string; | ||
| borderColor: string; | ||
| }[]; | ||
| }; |
There was a problem hiding this comment.
Change the name of the type
| }); | ||
|
|
||
| const handleChange = useCallback((newValue: SingleValue<SelectOption>) => { | ||
| if (newValue !== null) { |
There was a problem hiding this comment.
Suggested change
| if (newValue !== null) { | |
| if (newValue) { |
| </div> | ||
| </div> | ||
| <BarChart | ||
| chartData={dataMapping[currentData.value] || weeklyData} |
There was a problem hiding this comment.
Suggested change
| chartData={dataMapping[currentData.value] || weeklyData} | |
| chartData={dataMapping[currentData.value] ?? weeklyData} |
There was a problem hiding this comment.
I think it's better to create constant folder for all this data.
Comment on lines
152
to
155
| const [currentData, setCurrentData] = useState<SelectOption>({ | ||
| value: 'weekly', | ||
| label: 'Weekly', | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const [currentData, setCurrentData] = useState<SelectOption>({ | |
| value: 'weekly', | |
| label: 'Weekly', | |
| }); | |
| const [currentData, setCurrentData] = useState<SelectOption>(data[0]); |
Comment on lines
165
to
167
| callback: function (value: number): string { | ||
| return `${value}%`; | ||
| }, |
There was a problem hiding this comment.
Suggested change
| callback: function (value: number): string { | |
| return `${value}%`; | |
| }, | |
| callback: (value: number): string => `${value}%`;, |
Is it possible to do like this?
|
|
dimapopovych
previously approved these changes
Feb 29, 2024
…bsa-winter-2023-2024-lime into task/LIME-199-add-chart-for-progress
nikita-remeslov
approved these changes
Feb 29, 2024
nikita-remeslov
requested changes
Feb 29, 2024
frontend/src/bundles/overview/components/charts/types/bar-chart-data.types.ts
Outdated
Show resolved
Hide resolved
anton-otroshchenko
approved these changes
Mar 1, 2024
nikita-remeslov
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chart.mp4