This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
refactor: allow using server statically #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). netease-cloud-music-api-binaryify – ./🔍 Inspect: https://vercel.com/binaryify/netease-cloud-music-api-binaryify/BRb5TymBtEqfdFJXw1Q4NyQPcJjn netease-cloud-music-api – ./docs🔍 Inspect: https://vercel.com/binaryify/netease-cloud-music-api/97Akwp2yyA2g28DmFbvLJ1VRjRvr |
|
r? @Binaryify 謝謝 🙏 |
將原本 "NeteaseCloudMusicApi/server" 掃描 modules 目錄的部分抽出 server.js， 改移到 main.js。這樣使用者就有辦法只載入 靜態的伺服器部分（不動態載入模組）。 這個 patch 的 breaking changes 不易發生。 可作為 patch version 發佈。
pan93412
force-pushed
the
refactor/dynamic-to-main
branch
from
ac1b030
to
b02d4d5
Compare
|
嗯，这样是会更好点 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
將原本 "NeteaseCloudMusicApi/server" 掃描 modules 目錄的部分抽出 server.js，
改移到 main.js。這樣使用者就有辦法只載入靜態的伺服器部分（不動態載入模組）。
這個 patch 的 breaking changes 不易發生。可作為 patch version 發佈。