Syntax colour highlighting a pointer to a pointer in Go(lang) is off.

[irisida]

To me the syntax highlighting is buggy in Go when you have a pointer to a pointer. I would expect the double dereferencing operator to share the same syntax highlighting colour.

To Reproduce
Steps to reproduce the behavior:

1. install the extension
2. create a pointer to a pointer (as per attachment)

Expected behavior
Double dereferencing operator has unified syntax colour highlighting

Screenshots & Example Code

Desktop (please complete the following information):

• OS: Mac [10.15.7]
• VSCODE Version [1.51.1]
• Theme version [3.9.3]

Additional context
N/A

[Binaryify]

could you provide the code on your screenshot?

[irisida]

sure, apologies for not doing so initially.

package main

import "fmt"

func main() {

	p := fmt.Printf

	val := 100.0
	p1 := &val

	pp1 := &p1

	p("Type: %T Address: %p Value: %v\n", val, &val, val)
	p("Type: %T Address: %p Value: %v\n", p1, &p1, *p1)
	p("Type: %T Address: %p Value: %v\n", pp1, &pp1, *pp1)

	**pp1 = 500.

	p("Type: %T Address: %p Value: %v\n", val, &val, val)
	p("Type: %T Address: %p Value: %v\n", p1, &p1, *p1)
	p("Type: %T Address: %p Value: %v\n", pp1, &pp1, *pp1)
}

[tristan957]

Hi @irisida and @Binaryify,

I am coming from jeff-hykin/better-go-syntax#15. I believe this is a syntax issue if you look at the Textmate scopes. That repo is the VSCode upstream syntax repo for Go I believe. I think the One Dark Pro theme is not doing anything wrong here, and is only responding to what the syntax is telling it.

[Binaryify]

@tristan957 thank for the feedback

@irisida you could follow this issue jeff-hykin/better-go-syntax#15

[irisida]

Thanks for your reply. However, just for context....

The same code on other "one dark" alike themes, (atom, vivid etc) all handle the syntax highlighting as would be expected. As does most other installed themes, radical, synthwave84 etc... Of about 8-10 installed themes one dark pro is the only one to highlight the syntax in this manner.

Not disagreeing with the issue you're highlighting of course.

[Binaryify]

@irisida oh, I just check that, and it's indeed a bug

[Binaryify]

is this right?

@irisida

[irisida]

@Binaryify yes, that's the one.

[Binaryify]

just released a new version，you can check it now

[irisida]

Got it. Thank you! much appreciated.

[irisida]

moving to close issue

[irisida]

resolved. Many thanks. Corrected on 3.9.6

[tristan957]

Oh good to know that's it's a bug in both places.